[#642] Remove SDK, rewrite Build tab CLI-first#656
Conversation
1. Removed packages/sdk/ — inlined SDK source into packages/cli/src/sdk/ with .js extension fixes for ESM compatibility 2. Updated CLI imports from @plotlink/sdk to relative ./sdk/ paths 3. Removed @plotlink/sdk dependency from CLI package.json 4. Rewrote AgentBuild.tsx CLI-first: - Fixed CLI package name: plotlink-cli (not @plotlink/cli) - Fixed env vars: PLOTLINK_PRIVATE_KEY, PLOTLINK_RPC_URL, etc. - Added Filebase env vars for IPFS uploads - Removed all SDK references - Added /api/index/donation endpoint - Added StoryFactory and MCV2_Bond contract addresses 5. No SDK references remain in src/ or lib/ Fixes #642 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: REQUEST CHANGES
Summary
The SDK removal itself looks coherent, but the rewritten CLI-first Build tab still contains command examples that do not match the current CLI surface. Because this ticket is explicitly about fixing CLI/docs accuracy, those mismatches are still blocking.
Findings
- [high] The Build tab documents
plotlink claimas a zero-argument command that claims royalties from all storylines, but the actual CLI requires--address <tokenAddress>and only claims for a specific storyline token.- File:
src/components/AgentBuild.tsx:53 - File:
packages/cli/src/commands/claim.ts:9 - Suggestion: Update the command example and description to reflect the required
--addressoption and the per-token claim behavior, or change the CLI to match the documented all-storylines flow.
- File:
- [high] The documented
plotlink agent registerexample is missing required options, so users copying it from the Build tab will get a CLI validation error. The command requires--descriptionand--genrein addition to--nameand--model.- File:
src/components/AgentBuild.tsx:58 - File:
packages/cli/src/commands/agent-register.ts:15 - Suggestion: Show a fully valid example including the required description and genre flags, or relax the CLI requirements if those fields are no longer meant to be mandatory.
- File:
Decision
Requesting changes because the PR’s main user-facing goal is CLI/docs accuracy, and the Build tab still ships incorrect command guidance in two places.
- claim: added required --address flag, fixed description - agent register: added required --description and --genre flags - chain: noted --title is optional - create: noted Filebase requirement Addresses T2a review: Build tab examples now match actual CLI surface. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The latest revision fixes the CLI-first Build-tab inaccuracies I flagged: the documented claim flow now reflects the required token-address flag, and the agent register example now includes the required options. The SDK removal and CLI inlining remain coherent, and the user-facing docs now match the current CLI surface closely enough for this ticket.
Findings
- No blocking findings.
Decision
Approving because the current revision addresses the prior review feedback and satisfies the SDK-removal / CLI-doc accuracy goals of Queue #642 / agent-os#319.
2 participants
Summary
packages/sdk/: Inlined SDK source intopackages/cli/src/sdk/with ESM.jsextension fixes. CLI no longer depends on@plotlink/sdkworkspace package.AgentBuild.tsxCLI-first:plotlink-cli(was@plotlink/cli)PLOTLINK_PRIVATE_KEY,PLOTLINK_RPC_URL,PLOTLINK_FILEBASE_*@plotlink/sdkreferences remain insrc/orlib/Fixes #642
Tracks realproject7/agent-os#319
Test plan
grep -r '@plotlink/sdk' src/ lib/— zero resultsls packages/sdk— directory does not exist🤖 Generated with Claude Code